Win7 backend enhancements #4248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorodnic
reviewed
Jun 24, 2019
src/win7/win7-uvc.cpp
Outdated
| @@ -370,6 +370,8 @@ namespace librealsense | |||
| { | |||
| while (_keep_pulling_interrupts) | |||
| { | |||
| if (_device->deviceData.ctrl_if.bEndpointAddress < 0x80) | |||
There was a problem hiding this comment.
Need to not run poll_interrupts in this case
There was a problem hiding this comment.
I refactored and check it in init phase
| @@ -288,7 +294,6 @@ namespace librealsense | |||
| DEVICE_NOTIFY_WINDOW_HANDLE); | |||
| if (data->hdevnotifyUVC == nullptr) | |||
| { | |||
| UnregisterDeviceNotification(data->hdevnotifyHW); | |||
There was a problem hiding this comment.
This was an invalid call as it tried to do UnregisterDeviceNotification(**nullptr**);
which produces nothing.
Removing this call rectifies the flow
ev-mp
force-pushed
the
v2.23_win7_fixes
branch
2 times, most recently
from
fe7ecfb to
c582535
Compare
Static analizer fixes Deadlock reproduction with Log message Stall detection and wor-around add verbose log for winusb backend
Report partial frames Drop unnecessary logs. Fix format issues. Redirect all pritf calls to log Add pipe flush before start streaming to recover/reset previous state
Add missing include for VS2015 build Profile extrinsic graph performance: - add auxillary functionality - remove unused extrernal_extrinsic
ev-mp
force-pushed
the
v2.23_win7_fixes
branch
from
c582535 to
8122298
Compare
Remove unused variables Fix missing source reference Delete profiling and testing code Fix EOL/Tab inconsistencies Remove commented-out lines Replace writes to console Interrupt EP thread shall be opened for Upstream end-points only Change-Id: Ib9d6ea6e37d6d1525e6d96968e1e1087d8508651
ev-mp
force-pushed
the
v2.23_win7_fixes
branch
from
8122298 to
4569849
Compare
dorodnic
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set explicit timeout policy for bulk and interrupt endpoints
Fix dead-lock in bulk streaming end point.
Prevent polling of Host-originated EP.
Remove unused extrinsic member
Add handling for WinUSB_Open failure
Adding report for partial frames
Add EP flush on start/stop streaming to recover/reset previous state.
Fix memory and resource leak due to improper user callback management
Fix warnings identified with static profiler
Fix inconsistent EOL/ Tabs/ Trailing white spaces
Tests: