Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback realtime fix #2360

Merged
merged 12 commits into from
Sep 17, 2018
Merged

Conversation

matkatz
Copy link
Contributor

@matkatz matkatz commented Sep 6, 2018

No description provided.

@dorodnic
Copy link
Contributor

dorodnic commented Sep 6, 2018

This Pull-Request is aiming to address a widely reported issue with "non-real-time" playback from bag files. Related to #1579 #1919 #2102 (probably?) #2242 #2224 #2216 #2214 #2308

@dorodnic dorodnic requested a review from ev-mp September 6, 2018 14:09
@dorodnic
Copy link
Contributor

dorodnic commented Sep 6, 2018

The key design change is adding blocking_enqueue that prevents frames from being dropped at different stages of the pipe.
There are couple additional improvements, like playback pre-fetching that helps ensure the right frame is getting invoked.

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit-test with sw-device to verify deterministic palyback

@@ -248,6 +319,12 @@ class dispatcher
*wait_sucess = cv.wait_for(locker, std::chrono::seconds(10), [&]() { return invoked || _was_stopped; });
return *wait_sucess;
}

bool empty()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be const

@@ -256,4 +298,4 @@ namespace librealsense
private:
float m_stereo_baseline_mm;
};
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants