-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playback realtime fix #2360
Playback realtime fix #2360
Conversation
The key design change is adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit-test with sw-device to verify deterministic palyback
@@ -248,6 +319,12 @@ class dispatcher | |||
*wait_sucess = cv.wait_for(locker, std::chrono::seconds(10), [&]() { return invoked || _was_stopped; }); | |||
return *wait_sucess; | |||
} | |||
|
|||
bool empty() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be const
@@ -256,4 +298,4 @@ namespace librealsense | |||
private: | |||
float m_stereo_baseline_mm; | |||
}; | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add empty line
No description provided.