Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse order of sensor open in pipeline API #12899

Merged
merged 2 commits into from
May 7, 2024

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented May 6, 2024

The camera misbehaves when opening color sensor after depth sensor and it can reset the depth sensor on this case.
We know that if the depth sensor is configured, it will be the first sensor to open.
Here I used a reverse-iterator to open the sensors in reversed order, this way we know if we have depth sensor configures, it will be the last sensor to open.

@Nir-Az Nir-Az requested a review from maloel May 6, 2024 19:07
src/pipeline/resolver.h Outdated Show resolved Hide resolved
@maloel
Copy link
Collaborator

maloel commented May 7, 2024

We may want to add your simple test to LibCI in nightly runs?

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented May 7, 2024

We may want to add your simple test to LibCI in nightly runs?

It's already there, pipeline-start-stop
But we do it less iterations.
We can increase it and set it nightly only,
what do you think?

@maloel
Copy link
Collaborator

maloel commented May 7, 2024

It's already there, pipeline-start-stop But we do it less iterations

If it's not failing, it's not doing its job...
Yes, I think we need to be confident - and this is more in line with a stability test, non-functional: let's increase the runtime and make it nightly.

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented May 7, 2024

It's already there, pipeline-start-stop But we do it less iterations

If it's not failing, it's not doing its job... Yes, I think we need to be confident - and this is more in line with a stability test, non-functional: let's increase the runtime and make it nightly.

It's used to fail a lot when it was 10 loop, so I reduced it to 2.
I will change it to 50 nightly

@Nir-Az Nir-Az merged commit 88285da into IntelRealSense:development May 7, 2024
17 checks passed
@Nir-Az Nir-Az deleted the pipe-start-stop branch September 30, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants