Options: add BOOLEAN & ENUM; rs2_set_option_value #12708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Feb 29, 2024
OhadMeir
reviewed
Feb 29, 2024
maloel
changed the title
OhadMeir
reviewed
Mar 3, 2024
OhadMeir
reviewed
Mar 3, 2024
OhadMeir
reviewed
Mar 3, 2024
OhadMeir
reviewed
Mar 3, 2024
OhadMeir
reviewed
Mar 4, 2024
common/option-model.cpp
Outdated
| labels.push_back( endpoint->get_option_value_description( opt, i ) ); | ||
| } | ||
| int selected; | ||
| std::vector< const char * > labels = get_combo_labels( &selected ); | ||
| ImGui::PushStyleColor( ImGuiCol_TextSelectedBg, { 1, 1, 1, 1 } ); | ||
|
|
||
| try | ||
| { | ||
| int tmp_selected = selected; |
There was a problem hiding this comment.
Why do we need tmp_selected, can't we just use selected?
Don't we need to update selected later?
There was a problem hiding this comment.
You're right, it should be possible to just use selected. Doesn't look like selected is used after...
OhadMeir
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to previous options PR:
is_validmember tors2_option_valueBOOLEANandENUMoption typesget_value()returning json andget_value_type()rs2::options_list::get_supported_option_values()alongsideget_supported_options()(the latter only returned the option IDs; now you can get the values, as well)rs2_set_optionrs2_set_option_value, enabling string (IP address, enum, etc.) setsoptions_watcherquerying options that aren't enabled (and in thermal loop)