Separate frame archives for IR streams #12585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Jan 18, 2024
src/source.h
Outdated
| @@ -17,7 +18,7 @@ namespace librealsense | |||
| class LRS_EXTENSION_API frame_source | |||
| { | |||
| public: | |||
| using archive_id = std::pair< rs2_stream, rs2_extension >; | |||
| using archive_id = std::tuple< rs2_stream, int, rs2_extension >; | |||
There was a problem hiding this comment.
Can we add a name for the variable or a comment for what int is used for?
using archive_id = std::tuple< rs2_stream, int stream_index, rs2_extension >;
There was a problem hiding this comment.
Can't add a name, I will add a comment
Nir-Az
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplement for PR#12575.
Separating frame archives based on stream type are not always enough, the bug might still occur when IR1+IR2 are active together. This also separates the archives based on the stream index.
Tracked on [RSDEV-599]