fix non-DDS settings initialization in rs-terminal and -enumerate-devices #12567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Jan 11, 2024
| @@ -355,14 +355,16 @@ int main(int argc, char** argv) try | |||
| } | |||
|
|
|||
| // Obtain a list of devices currently present on the system | |||
| json settings; | |||
| json settings = json::object(); | |||
There was a problem hiding this comment.
Should we update all occurrences of json j; to json j = json::object() or is it relevant only to the settings usage?
There was a problem hiding this comment.
Relevant only to the settings
Can we test it here? Prevent further cases of null json |
No, I think it's a valid complaint that the settings should make sense -- and sending |
OhadMeir
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's really hard to see, but when we pass in settings to the context they must be either empty or an object. But json initializes to
nulland librealsense correctly throws.This fixes two use-cases which were missed before, in rs-terminal and rs-enumerate-devices -- especially outside of DDS mode which usually force an object.
Tracked on [HSD-15015096962]