Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions when closing the viewer #12554

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

OhadMeir
Copy link
Contributor

@OhadMeir OhadMeir commented Jan 4, 2024

options-watcher query loop exposed some problems when closing the application.
Querying options while in the destruction process exposed some race cases where option tried to query a sensor reference that was already destructed.

Now the subdevice-model cancels the on_options_changed subscription and options use weak_ptr to sensor not direct reference.

@OhadMeir OhadMeir requested a review from Nir-Az January 4, 2024 15:06
@OhadMeir OhadMeir marked this pull request as ready for review January 4, 2024 15:06
src/ds/d500/d500-device.cpp Outdated Show resolved Hide resolved
@Nir-Az Nir-Az merged commit 12f5a7e into IntelRealSense:development Jan 7, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants