Fix: Should not set HDR when it is already enabled #12511
Conversation
| @@ -187,10 +187,6 @@ namespace librealsense | |||
|
|
|||
| synthetic_sensor::open(requests); | |||
|
|
|||
| // needed in order to restore the HDR sub-preset when streaming is turned off and on | |||
| if (_hdr_cfg && _hdr_cfg->is_enabled()) | |||
There was a problem hiding this comment.
This piece of code is invoked every time when the streams are opened. Since, FW will throw an error if we try to set it when it is already enabled, removing this code.
There was a problem hiding this comment.
I am not sure that is what we want, if the user explicitly turned on the hdr , if he closed the stream he expect it to stay on, even if we will block him from changing the exp/gain right?
This will even cause a confusion in the UI IMO, the checkbox will be marked but it will be off in FW.
according to this code Alex answer was wrong and streaming stop turn off HDR preset, right?
There was a problem hiding this comment.
Quoting Alex's response:
"SubPreset mechanism stays active in FW (even during start and stop streaming commands) till SETSUBPRESET 0 call."
So, my understanding from Alex's response is:
- Stream CLOSE doesn't affect HDR.
- So, when the stream is reopened, no need to enable HDR again.
There was a problem hiding this comment.
It looks like this was not the case when this was implemented originally.
Can we verify this behavior and verify he is right?
There was a problem hiding this comment.
I verified the following scenario from RS Viewer:
- HW Reset
- Set Exp.1 = 32000, Exp.2 = 1
- Enable HDR
- Open Depth stream
- From frame Metadata, verified that the Actual Exposure values to be 32000 & 1
- Close and Reopen Depth stream
- From frame Metadata, verified that the Actual Exposure values are still 32000 & 1
Do you want me to verify any other scenarios?
There was a problem hiding this comment.
Thanks , that was the required scenario to test
Arun-Prasad-V
force-pushed
the
dynamic_hdr_subpreset
branch
2 times, most recently
from
f9886e3 to
ad95819
Compare
Arun-Prasad-V
force-pushed
the
dynamic_hdr_subpreset
branch
2 times, most recently
from
dc14073 to
30c3f90
Compare
Arun-Prasad-V
force-pushed
the
dynamic_hdr_subpreset
branch
3 times, most recently
from
437ac2a to
7876aa9
Compare
Arun-Prasad-V
force-pushed
the
dynamic_hdr_subpreset
branch
from
7876aa9 to
ebd3f89
Compare
Tracked on LRS-962
From FW version 5.14.x.x, the FW doesn't support updating the HDR presets when HDR is already enabled.