Removing external libusb usage #12340
Conversation
Tamir91
force-pushed
the
removing-external-libusb
branch
from
10eded3 to
8671506
Compare
|
@maloel looks like windows rsusb compiled w/o internal libusb |
It could be that's it's not used -- like I said, pybackend should not be dependent on it. Maybe other places, too. |
Tamir, please try adding the pybackend cmake flag to windows gha to check and try to see when we build it |
|
should be |
|
I checked number builds on Windows with |
| find_package_handle_standard_args(usb LIBUSB_LIB LIBUSB_INC) | ||
|
|
||
| add_library(usb INTERFACE) | ||
| if (USB_FOUND) |
There was a problem hiding this comment.
Who turn this flag on?
When will it be off?
There was a problem hiding this comment.
I not found place where we create or change this flag, only 1 usage.
Is this unnecessary flag?
There was a problem hiding this comment.
Read online..
I think find_package_handle_standard_args(usb set it
There was a problem hiding this comment.
Please make sure what happened when it is not found.
Maybe we need an error?
There was a problem hiding this comment.
Read online..
I think
find_package_handle_standard_args(usbset it
Oh, I Already read about it. USB_FOUND will true if LIBUSB_LIB LIBUSB_INC will be found.
USB_FOUND is false if libusb-1-dev not installed and installation crashing on install(TARGETS usb EXPORT realsense2Targets) line
We can add:
message(FATAL_ERROR "decription") - stop processing and generation.
or
message(SEND_ERROR "decription") - continue processing, but skip generation.
There was a problem hiding this comment.
So are you saying windows has libusb installed?
And on windows USB_FOUND = true?
There was a problem hiding this comment.
I see in a logs LIBUSB_LIB (missing: LIBUSB_INC) and the code in if not executing (USB_FOUND = false).
But the viewer run after building.
Are you think it may cause error in some places?
There was a problem hiding this comment.
So it does not get into the if and the install does not complain??
There was a problem hiding this comment.
Yes, it does not get into the if. But the viewer run correctly.
There was a problem hiding this comment.
Show me the output logs tomorrow please
windows -DFORSE_RSUSB_BACKEND=ON external libusb removed
This reverts commit 072849b.
Tamir91
force-pushed
the
removing-external-libusb
branch
from
c41cdc1 to
de586da
Compare
Tamir91
force-pushed
the
removing-external-libusb
branch
from
b83ea9f to
e6f7cec
Compare
|
We can't remove libusb usage. A libusb will be updated with latest tag. |
Tracked on [LRS-784]