Restore calibration changed options only after apply or dismiss #12128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
approved these changes
Aug 22, 2023
remibettan
pushed a commit
to remibettan/librealsense
that referenced
this pull request
Sep 3, 2023
…s only after apply or dismiss
Nir-Az
added a commit
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Tracked by] LRS-666
Options that are changed during the calibration are restored only after the user applies or dismisses the calibration process. Previously were restored after the calculations where over but before applying.
Thermal loop is disabled also for GT calculation (previously was disabled for all other calibrations).
Added
_to member names.