Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev with hkr base #12041

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Dev with hkr base #12041

merged 7 commits into from
Aug 2, 2023

Conversation

remibettan
Copy link
Contributor

Tracked by: LRS-839

@remibettan remibettan requested review from maloel and Nir-Az July 26, 2023 10:17
maloel
maloel reviewed Jul 27, 2023
View reviewed changes
src/ds/d500/d500-color.h Outdated Show resolved Hide resolved
@maloel
Copy link
Collaborator

maloel commented Jul 27, 2023

I'm seeing:
3 compilation warnings found; 1 expected
In the Windows build. Can you check, please?

@Nir-Az
Copy link
Collaborator

Nir-Az commented Jul 27, 2023

I see
third-party/json.hpp
This file addition, looks like a mistake as now it is cloned during cmake

maloel
maloel reviewed Aug 1, 2023
View reviewed changes
src/ds/d500/d500-color.h Outdated Show resolved Hide resolved
@remibettan remibettan requested review from maloel and Nir-Az August 1, 2023 12:33
@maloel maloel merged commit 4666b29 into IntelRealSense:development Aug 2, 2023
maloel
maloel reviewed Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maloel maloel maloel left review comments

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remibettan @maloel @Nir-Az