Close laser emitter on Focal Length calibration #11995
Conversation
|
How hard it is to add some kind of UT for this? |
|
I Don't think if it possible since viewer code is not reflected in the API |
No python API for it? python calibration example? |
common/on-chip-calib.cpp
Outdated
| _sub->s->set_option(RS2_OPTION_EMITTER_ENABLED, 0.0f); | ||
| if (_sub->s->supports(RS2_OPTION_THERMAL_COMPENSATION)) | ||
| _sub->s->set_option(RS2_OPTION_THERMAL_COMPENSATION, 0.f); | ||
| // TODO - When implementing UV mapping - should remove from here and handle in process_flow() |
There was a problem hiding this comment.
What does this means?
UV mapping is implemented for D400 devices, no?
There was a problem hiding this comment.
Like discussed lets rephrased to UV mapping based calibration
There was a problem hiding this comment.
Rephrased to UV mapping calibration
| if (_sub->s->supports(RS2_OPTION_THERMAL_COMPENSATION)) | ||
| _sub->s->set_option(RS2_OPTION_THERMAL_COMPENSATION, 0.f); | ||
| // TODO - When implementing UV mapping - should remove from here and handle in process_flow() | ||
| set_laser_emitter_state( off_value ); |
There was a problem hiding this comment.
I see you removed the supports check, why?
Don't needed anymore?
There was a problem hiding this comment.
Maybe add it inside the helper funcs?
There was a problem hiding this comment.
It is checked in the helper functions. More "clean" this way, and less code repetitions
common/on-chip-calib.cpp
Outdated
| @@ -516,8 +565,8 @@ namespace rs2 | |||
| break; | |||
| } | |||
|
|
|||
| if (_sub->s->supports(RS2_OPTION_EMITTER_ENABLED)) | |||
| _sub->s->set_option(RS2_OPTION_EMITTER_ENABLED, 0.0f); | |||
| // TODO - When implementing UV mapping - should remove from here and handle in process_flow() | |||
There was a problem hiding this comment.
Same, moved into set_laser_emitter_state function
Close laser emitter during FL calibration and verify other calibration work according to table by algo team
Tracked on [LRS-666]