Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live-frames-fps test monitors frame drops #11668

Merged
merged 5 commits into from
Apr 19, 2023

Conversation

OhadMeir
Copy link
Contributor

@OhadMeir OhadMeir commented Apr 11, 2023

[LRS-754]
Updated live-frames-fps test to solve the 60 FPS problem, KPI is 5%

@OhadMeir OhadMeir requested a review from Nir-Az April 11, 2023 07:53
@OhadMeir OhadMeir removed the request for review from Nir-Az April 11, 2023 08:55
@OhadMeir OhadMeir marked this pull request as draft April 11, 2023 08:55
@OhadMeir
Copy link
Contributor Author

According to mail from Evgeni, need to also unset "Auto Exposure Priority" option

@Nir-Az
Copy link
Collaborator

Nir-Az commented Apr 11, 2023

According to mail from Evgeni, need to also unset "Auto Exposure Priority" option

Note that now the log.e can fail the test on frame drops.
We can leave it and think if to change to log.w in the future..

@OhadMeir
Copy link
Contributor Author

Note that now the log.e can fail the test on frame drops. We can leave it and think if to change to log.w in the future..

I was not sure that log.w will print, depending on LibCI log level configuration.

@Nir-Az
Copy link
Collaborator

Nir-Az commented Apr 11, 2023

Note that now the log.e can fail the test on frame drops. We can leave it and think if to change to log.w in the future..

I was not sure that log.w will print, depending on LibCI log level configuration.

LibCI use debug level, so you can see even log.i() and log.out() which is parallel to print

@Nir-Az
Copy link
Collaborator

Nir-Az commented Apr 13, 2023

Please also replace ds with cs.

ds.set_option(rs.option.enable_auto_exposure, 1)

@OhadMeir OhadMeir marked this pull request as ready for review April 19, 2023 13:37
@OhadMeir OhadMeir requested a review from Nir-Az April 19, 2023 13:37
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit c8749cb into IntelRealSense:development Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants