Threading optimizations in DDS #11580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Mar 19, 2023
|
|
||
| rsutils::time::stopwatch stopwatch; | ||
| _on_data_available(); | ||
| if( stopwatch.get_elapsed() > std::chrono::milliseconds( 500 ) ) |
There was a problem hiding this comment.
Why 500? Should be configurable, maybe FPS dependent.
Not for this PR but we should add a task to do it later
There was a problem hiding this comment.
Right, can be whatever we deem is right, I picked half a second rather arbitrarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibCI was hanging on some tests, mainly non-dds-related ones, because of timeouts. There were infinite waits somehow on the closing of resources.
This cleans up a lot and makes things much better.
This should fix libCI so I'll merge this first and then the other PRs...