fix bug in rspy.test.check_throws #11441
Conversation
| @@ -136,7 +136,7 @@ def print_stack(): | |||
| """ | |||
| Function for printing the current call stack. Used when an assertion fails | |||
| """ | |||
| log.out( 'Traceback (most recent call last):' ) | |||
| log.e( 'Traceback (most recent call last):' ) | |||
There was a problem hiding this comment.
Why should the print_stack function fail the test?
The calling function should do that no?
There was a problem hiding this comment.
I just wanted the stack to show with a red -E-, which this does. The stack is only printed on failure.
There was a problem hiding this comment.
log.e increase the error count
librealsense/unit-tests/py/rspy/log.py
Line 145 in b874e42
So that's why I asked..
You would expect that some error checking will increase it and not a stack print function..
But you saw the output and if you think it's OK I will not object :)
There was a problem hiding this comment.
I'll check it and make sure
There was a problem hiding this comment.
In unit-tests/run-unit-tests.py, it fails the run if log.n_errors() returns non-zero.
But there's no real count per-se. It's just used as a boolean. I'm OK with a stack trace being considered an error there, too.
Also, run-unit-tests is not a test, so does not print stack traces -- those are only printed inside each actual test, and rspy.test uses a different mechanism (test.n_failed_tests) to detect failure.
OK?
If nothing was thrown, it failed but nothing was printed...