Metadata permission #11408
Merged
Metadata permission #11408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Feb 7, 2023
common/metadata-helper.cpp
Outdated
| @@ -229,7 +231,10 @@ namespace rs2 | |||
| CloseHandle(sei.hProcess); | |||
| if (exitCode) | |||
| throw std::runtime_error("Failed to set metadata registry keys!"); | |||
| return true; | |||
| // returning false here so that the instandce that runs "not as admin" | |||
Nir-Az
reviewed
Feb 7, 2023
common/metadata-helper.cpp
Outdated
| // returning false here so that the instandce that runs "not as admin" | ||
| // will not even try to do the writing to registry job | ||
| // This job is done by the "run as admin" instance. | ||
| return false; |
There was a problem hiding this comment.
We have an if and an else both returning false?
and more code after? return true?
Take another look please..
There was a problem hiding this comment.
IMO, this is correct.
Let's talk about it.
remibettan
force-pushed
the
metadata_permission
branch
from
17565cd to
685b4db
Compare
|
Looks great, I retriggered the CI, once we see a green light I will approve :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: LRS-663