Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable d457 ros #11131

Closed
wants to merge 1 commit into from
Closed

Conversation

hsuys
Copy link
Contributor

@hsuys hsuys commented Nov 22, 2022

Adding accel as the default streaming for the D457 IMU profile to prevent error when launch realsense2_camera.

@Nir-Az Nir-Az changed the base branch from master to D4XX_MIPI November 22, 2022 05:13
@Nir-Az Nir-Az requested a review from remibettan November 22, 2022 05:14
@Nir-Az
Copy link
Collaborator

Nir-Az commented Nov 22, 2022

@hsuys Thanks for the PR.
Can you elaborate on the error you saw?
Your change effect all d400 cameras..

@hsuys
Copy link
Contributor Author

hsuys commented Nov 22, 2022

Thank you, @Nir-Az. Without a default stream profile for the IMU, User will get "No Default Profile Found" error when launching the D457.

@Nir-Az Nir-Az changed the base branch from D4XX_MIPI to development January 9, 2023 06:51
@Nir-Az
Copy link
Collaborator

Nir-Az commented Jan 9, 2023

@hsuys sorry for the delay,
The best thing we can do is change ROS to to enforce a default profile for each stream.
Since we are not getting into this can you please fix the conflict so I can merge it?
We will later on work on ROS wrapper behavior
Thanks

@Nir-Az
Copy link
Collaborator

Nir-Az commented Jan 26, 2023

@hsuys sorry for the delay, The best thing we can do is change ROS to to enforce a default profile for each stream. Since we are not getting into this can you please fix the conflict so I can merge it? We will later on work on ROS wrapper behavior Thanks

Hi @hsuys this was addressed here: IntelRealSense/realsense-ros#2601

I will close this issue as we do not wish to add default streams for IMU on D457 currently.
Thanks for your effort

@Nir-Az Nir-Az closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants