Fix cast/conversion issue when using mixed int/float types #10839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
force-pushed
the
fix_y12i_heuristic
branch
2 times, most recently
from
9d840a8 to
d9814da
Compare
(cherry picked from commit 3e8b34a)
ev-mp
force-pushed
the
fix_y12i_heuristic
branch
from
d9814da to
1f30ed7
Compare
maloel
reviewed
Aug 29, 2022
| // The calibration format Y12BPP is modified to be 32 bits instead of 24 due to an issue with MIPI driver | ||
| // and padding that occurs in transmission. | ||
| // For D4xx cameras the original 24 bit support is achieved by comparing actual vs expected size: | ||
| // when it is exactly 75% of the MIPI-generated size (24/32bpp), then 24bpp-sized image will be processed |
There was a problem hiding this comment.
The calibration format is supposed to be 24 bpp?
With D457 24 bpp are sent, but packed in a buffer that's sized for 32 bpp, so the last 25% is garbage?
This explanation needs to be very clear.
The cast (byte*) on line 473 is a bad idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for integer type miscalculated in conversion. Corrects #10794
(cherry picked from commit 3e8b34a)
Tracked by: DSO-18458