Add EMON, VTune, psrecord, ITTpy support in benchmarks #115
Conversation
masdevas
force-pushed
the
dev/amorkovk-analysis
branch
from
943c545 to
fb5575f
Compare
masdevas
force-pushed
the
dev/amorkovk-analysis
branch
from
fb5575f to
1b80bd8
Compare
|
|
||
|
|
||
| def time_box_filter(func, *args, n_meas, time_limit, **kwargs): | ||
| def detect_LLC_size(): | ||
| with open('/sys/devices/system/cpu/cpu0/cache/index3/size', 'r') as f: |
There was a problem hiding this comment.
Add support for all systems or exception for non-Linux
| print('# Intel(R) Extension for Scikit-learn case result:') | ||
| print(json.dumps(output, indent=4)) | ||
| print('# Intel(R) Extension for Scikit-learn case finished.') |
There was a problem hiding this comment.
sklbench may not use sklearnex, so, this outputs will be confusing for some cases
| ################################################################################## | ||
|
|
||
| #ruby interpreter, change it according to the path where ruby is installed in your system | ||
| #RUBY_PATH="c:\Ruby192\bin\ruby.exe" |
There was a problem hiding this comment.
Are these commented lines required to be included?
| fit_time, _ = bench.measure_function_time(regr.fit, X_train, y_train, box_filter_measurements=params.box_filter_measurements_fit, time_limit=params.time_limit_fit, params=params, stage='fit') | ||
|
|
||
| # Time predict | ||
| predict_time, yp = bench.measure_function_time(regr.predict, X_test, params=params) | ||
| predict_time, yp = bench.measure_function_time(regr.predict, X_test, box_filter_measurements=params.box_filter_measurements_infer, time_limit=params.time_limit_infer, params=params, stage='infer') |
There was a problem hiding this comment.
Why only ridge regression includes box_filter_measurements, time_limit and params arguments?
| @@ -119,6 +279,15 @@ def get_configs(path: Path) -> List[str]: | |||
| common_params = config['common'] | |||
| for params_set in config['cases']: | |||
| params = common_params.copy() | |||
| # print('PRE PARAMS:', params) | |||
There was a problem hiding this comment.
Remove commented code
| #RUBY_OPTIONS=--server -J-Xmx5g -J-Xms5g --1.8 | ||
|
|
||
| #Number of threads to process data in parallel. Typically it should equal to the number of logical CPUs in your processing system. | ||
| PARALLELISM=24 |
There was a problem hiding this comment.
Avoid hardcoded number of threads
| @@ -35,7 +35,7 @@ def main(): | |||
| # 'kdtree' when running unpatched scikit-learn. | |||
|
|
|||
| # Time fit | |||
| time, _ = bench.measure_function_time(dbscan.fit, X, params=params) | |||
| time, _ = bench.measure_function_time(dbscan.fit, X, params=params, stage='fit') | |||
There was a problem hiding this comment.
Try to align stage and stages arguments of bench.measure_function_time and bench.print_output if possible
| analysis_stage_collection = ['default'] | ||
| if analysis_prefix != None: | ||
| analysis_stage_collection.extend(['fit', 'infer']) | ||
| for analysis_stage in analysis_stage_collection: |
There was a problem hiding this comment.
Check that non-measured stage is not included in single benchmark output
|
|
||
| def flush_caches(): | ||
| flush_datafile = 'data/flush_data.npy' | ||
| if os.path.exists(flush_datafile): |
There was a problem hiding this comment.
You can add a check to see if the file is in datasets_root
| try: | ||
| import itt | ||
| itt_module_installed = True | ||
| except: |
There was a problem hiding this comment.
| except: | |
| except ImportError: |
| iterations_to_flush = 3 | ||
| try: | ||
| from sklearnex.cluster import KMeans | ||
| except: |
There was a problem hiding this comment.
| except: | |
| except ImportError: |
| if key in analysis_config.keys(): | ||
| args = dict_to_cmd_args(analysis_config[key]) | ||
| return args | ||
| else: |
There was a problem hiding this comment.
What condition does this else belong to?
Same for the 107 line
No description provided.