Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dpnp.issubsctype function #1996

Merged
merged 16 commits into from
Aug 19, 2024
Merged

Remove dpnp.issubsctype function #1996

merged 16 commits into from
Aug 19, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 18, 2024 •
edited
Loading

In numpy 2.0 numpy.issubsctype function was removed and it was propose to use numpy.issubdtype instead.

Since the previously dpnp implementation of issubsctype function fully leverages on numpy, the PR proposes to remove dpnp.issubsctype function and to provide only dpnp.issubdtype per numpy 2.0 recommendation.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

antonwolfy and others added 14 commits August 14, 2024 16:49
@antonwolfy antonwolfy self-assigned this Aug 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 18, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review August 18, 2024 12:12
vtavana
vtavana approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

doc/reference/dtype.rst Show resolved Hide resolved
Base automatically changed from allow-running-tests-with-numpy-2.0 to master August 19, 2024 09:23
@antonwolfy antonwolfy merged commit 256ce60 into master Aug 19, 2024
38 of 46 checks passed
@antonwolfy antonwolfy deleted the remove-issubsctype branch August 19, 2024 12:49
github-actions bot added a commit that referenced this pull request Aug 19, 2024
@github-actions
Remove dpnp.issubsctype function (#1996)
12ec560 
* Remove alias on numpy.complex_

* Remove alias on numpy.cfloat

* Remove alias on numpy.float and numpy.float_

* Remove alias on numpy.float and numpy.singlecomplex

* Remove aliases on numpy.Inf, numpy.Infinity and numpy.infty constants

* Get rid of dpnp.float in the code

* Remove aliases on numpy.NAN and numpy.NaN constants

* Remove aliases on numpy.NINF and numpy.PINF constants

* Remove aliases on numpy.NZERO and numpy.PZERO constants

* Remove use of removed numpy.longcomplex dtype

* Use proper import of numpy exceptions

* Applied pre-commit hooks

* Remove dpnp.issubsctype per numpy 2.0 migration guide

* Remove dpnp.sctype2char and dpnp.maximum_sctype from generating documentatation, because the similar functions were removed in NumPy 2.0 256ce60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana