Skip to content

Commit

Permalink
Remove TODO from the code as no plan to support negative values in sh…
Browse files Browse the repository at this point in the history
…ape setter (#2032)
  • Loading branch information
antonwolfy committed Sep 14, 2024
1 parent d106341 commit b41b237
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions dpnp/dpnp_iface_mathematical.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,7 @@ def _gradient_num_diff_2nd_order_interior(
# fix the shape for broadcasting
shape = [1] * ndim
shape[axis] = -1
# TODO: use shape.setter once dpctl#1699 is resolved
# a.shape = b.shape = c.shape = shape

a = a.reshape(shape)
b = b.reshape(shape)
c = c.reshape(shape)
Expand Down
3 changes: 2 additions & 1 deletion tests/third_party/cupy/core_tests/test_ndarray.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,8 @@ def test_shape_set(self, xp):
return xp.array(arr.shape)

@pytest.mark.skip(
"dpctl-1699: shape setter does not work with negative shape"
"dpctl-1699: shape setter does not work with negative shape "
"(no plan to support that)"
)
@testing.numpy_cupy_array_equal()
def test_shape_set_infer(self, xp):
Expand Down

0 comments on commit b41b237

Please sign in to comment.