-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Technical debt #1852
Technical debt #1852
Conversation
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_99 ran successfully. |
2237e80
to
158cd6a
Compare
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_104 ran successfully. |
Also removed unnecessary static qualifier near constexpr constant in a local code scope.
@oleksandr-pavlyk |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_105 ran successfully. |
@ndgrigorian Thank you for catching the omissions. I have pushed two commits with fixes. |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_107 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR
#include <stdexcept>
to files that usestd::runtime_error
exception#include <new>
to files that usestd::bad_alloc
exceptionsycl::get_kernel_bundle<sycl::bundle_state::executable>
now usecgh.use_kernel_bundle(kb)
to avoid recompiling that kernel.