Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical debt #1852

Merged
merged 25 commits into from
Oct 1, 2024
Merged

Technical debt #1852

merged 25 commits into from
Oct 1, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This PR

  • adds missing #include <stdexcept> to files that use std::runtime_error exception
  • adds missing #include <new> to files that use std::bad_alloc exception
  • functions that submit kernels which are compiled by means of calling sycl::get_kernel_bundle<sycl::bundle_state::executable> now use cgh.use_kernel_bundle(kb) to avoid recompiling that kernel.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Sep 30, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_99 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

Base automatically changed from add-as-contig-specialization to master September 30, 2024 20:13
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_104 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Sep 30, 2024

Coverage Status

coverage: 87.907%. remained the same
when pulling c04db57 on technical-debt
into 9085854 on master.

Also removed unnecessary static qualifier near constexpr constant
in a local code scope.
@ndgrigorian
Copy link
Collaborator

@oleksandr-pavlyk
Seems dpctl4pybind11.hpp includes exception instead of stdexcept, kernels/elementwise_functions/common.hpp doesn't include stdexcept either. Those were the only cases I found left (outside of the examples).

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_105 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@oleksandr-pavlyk
Copy link
Collaborator Author

@ndgrigorian Thank you for catching the omissions. I have pushed two commits with fixes.

Copy link

github-actions bot commented Oct 1, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_107 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit f0f7837 into master Oct 1, 2024
50 of 51 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the technical-debt branch October 1, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants