Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling accessors for Sequences #822

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

matthewshaer
Copy link
Contributor

Summary

I want to be able to see how you access a child from it's parent. In the previous diff I handled direct children. This diff handles sequences. So instead of referring to child[3] it becomes args[2] which is actually how you would refer to it

Test Plan

Tested locally and updated the unit test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants