Replace various std::pow(2.0, x) calls with 1ULL << x
#5257
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
dzenanz
approved these changes
Feb 25, 2025
Modules/Filtering/AnisotropicSmoothing/include/itkAnisotropicDiffusionImageFilter.hxx
Show resolved
Hide resolved
N-Dekker
commented
Feb 25, 2025
| // using BoundingBoxVerticesType = itk::FixedArray< | ||
| // LabelPointType,std::pow(2.0,Self::ImageDimension)>; | ||
| // using BoundingBoxVerticesType = itk::FixedArray<LabelPointType, 1ULL << Self::ImageDimension>; |
There was a problem hiding this comment.
This looks like the original idea was to make BoundingBoxVerticesType an itk::FixedArray, instead of a std::vector, but then that seemed impossible because std::pow wasn't constexpr. Just guessing. 🤷
Follow-up to pull request InsightSoftwareConsortium#5252 commit 2bd9f0a "STYLE: Replace `std::pow(2, dim)` calls with `1 << dim`" Included replacing `std::pow(2, dim)` calls in comments.
Using left-shift instead of `std::pow(2, x)` allows the local variable `BSplineTransformDomainEpsilon` to be declared `constexpr`.
N-Dekker
force-pushed
the
Replace-pow-of-two
branch
from
d9c8a6e to
273ecdb
Compare
dzenanz
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::pow(2, dim)calls with1 << dim#5252