-
-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gdcm #4647
Update gdcm #4647
Conversation
Code extracted from: https://github.com/malaterre/GDCM.git at commit 2eaae2091ed90566597c34886dd17d639c1ba8d5 (release).
* upstream-GDCM: GDCM 2024-05-03 (2eaae209)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hjmjohnson thank you!
4926c2f
into
InsightSoftwareConsortium:master
This caused another behaviour change in our application's test suite... We have a test that reads a single DICOM file (just one slice) with Since it's just one slice, I'm not really sure if 1 or 5 is the right answer. I've built GDCM master, and |
@thewtex @malaterre @hjmjohnson so we looked at this more... it seems the behaviour has only changed when there is just 1 DICOM slice. So before this PR, with either 1 or 2 files in the folder, we get: spacing: {0.661468, 0.661468, 1.0} After this PR, with 1 file we get: spacing: {0.661468, 0.661468, 5.0} but with 2 files we get: spacing: {0.661468, 0.661468, 1.0} Is this a deliberate change? BTW the file we are using is |
@seanm there is a flag that needs to be passed to |
@thewtex thanks for your reply! So without
and with
Interesting. OK, so this explains differences using But we're using ITK. We use What we're trying to understand is if this behaviour change between ITK 5.3 and 5.4 is deliberate / correct / buggy. |
Release 3.0.24
COMP: Fix for gcc13.2 compiler test failures
Another pass for SIEMENS/MOSAIC
Check for Secondary Capture spacing following DICOM Part 3 Sect A.8.1.3
PR Checklist