Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add itkwasm-downsample-cucim #1058

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Feb 7, 2024

This is based on the itk_cucim package work. _discrete_gaussian.py by Greg Lee is copied directly.

We are currently getting sporatic differences in the test output of 1.

This is based on the itk_cucim package work. _discrete_gaussian.py by
Greg Lee is copied directly.

We are currently getting sporatic differences in the test output of 1.

Co-authored-by: Gregory Lee <grlee77@gmail.com>
@thewtex
Copy link
Member Author

thewtex commented Feb 7, 2024

@grlee77 @gigony please take a look 🙏 . I see affine_transform in cucim: https://github.com/rapidsai/cucim/blob/d4ec01eb53afceaaeec36856e1dcbf2c282659d0/python/cucim/src/cucim/skimage/_vendored/_ndimage_interpolation.py#L344-L356 but how to import it? Which is better to use -- that or the one in cupy?

The motivation is to provide NVIDIA acceleration when available for OME-Zarr generation per thewtex/ngff-zarr#68

@thewtex
Copy link
Member Author

thewtex commented Feb 7, 2024

@tbirdso @agirault @jjomier per our discussion at the hackathon, we can use GPU representations on the image.data pixel buffer. In this case, it is a cupy array. This will reside on the GPU until needed in the CPU memory. In the test here, that is happening in write_image.

@thewtex
Copy link
Member Author

thewtex commented Feb 26, 2024

Failing CI is unrelated.

@thewtex thewtex merged commit 3bd777e into InsightSoftwareConsortium:main Feb 26, 2024
113 of 125 checks passed
@thewtex thewtex deleted the cucim branch February 26, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant