-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add questionings filters #98
base: develop
Are you sure you want to change the base?
Conversation
inputProps: (name: any) => { | ||
id: any; | ||
name: any; | ||
value: any; | ||
onChange: (e: any) => void; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essayer de récupérer le type de inputProps de Select pour éviter les any ici. Au delà de ça je trouve ça étrange de passer une fonction plutôt qu'un objet contenant les props.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pour ce qui est de l'inputProps que je passais en fonction en fait je reprenais l'inputProps qui était renvoyé par useSearchFilter tel quel mais c'est vrai que c'est mieux de passer un objet 👍
inputProps: (name: "searchParam") => { | ||
id: "searchParam"; | ||
name: "searchParam"; | ||
value: string; | ||
onChange: (e: any) => void; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essayer de récupérer le type de inputProps de TextField pour éviter les any ici. Au delà de ça je trouve ça étrange de passer une fonction plutôt qu'un objet contenant les props.
Quality Gate passedIssues Measures |
No description provided.