Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add questionings filters #98

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

RenauxLeaInsee
Copy link
Contributor

No description provided.

@RenauxLeaInsee RenauxLeaInsee self-assigned this Dec 2, 2024
Comment on lines 23 to 28
inputProps: (name: any) => {
id: any;
name: any;
value: any;
onChange: (e: any) => void;
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essayer de récupérer le type de inputProps de Select pour éviter les any ici. Au delà de ça je trouve ça étrange de passer une fonction plutôt qu'un objet contenant les props.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour ce qui est de l'inputProps que je passais en fonction en fait je reprenais l'inputProps qui était renvoyé par useSearchFilter tel quel mais c'est vrai que c'est mieux de passer un objet 👍

Comment on lines 10 to 15
inputProps: (name: "searchParam") => {
id: "searchParam";
name: "searchParam";
value: string;
onChange: (e: any) => void;
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essayer de récupérer le type de inputProps de TextField pour éviter les any ici. Au delà de ça je trouve ça étrange de passer une fonction plutôt qu'un objet contenant les props.

Copy link

sonarqubecloud bot commented Dec 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants