Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove unused edited forced previous etc values #280

Merged
merged 3 commits into from
Feb 17, 2025
Merged

refactor!: remove unused edited forced previous etc values #280

merged 3 commits into from
Feb 17, 2025

Conversation

RemiVerriez
Copy link
Contributor

  • Suppression des modalités non valorisées de la propriété "values" (EDITED, FORCED, INPUTTED, PREVIOUS) aux emplacements adéquats.
  • Ajustement en conséquence des tests liés à ces changements.

PS : je n'ai pas trouvé l'emplacement pour modifier la version.

nsenave
nsenave approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@nsenave nsenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impec 👌 juste

  • ici on est plus sur de refactor que sur du feat
  • penser à bump la version (on va faire monter la majeure vu que c'est du breaking change pour les utilisateurs éventuels des props "edited" etc.)

@nsenave nsenave changed the base branch from v3-next to v3-main February 17, 2025 15:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nsenave nsenave changed the title Feat/supprimer modalites values refactor!: remove unused edited forced previous etc values Feb 17, 2025
@nsenave nsenave merged commit d553994 into v3-main Feb 17, 2025
3 checks passed
@nsenave nsenave deleted the feat/supprimer-modalites-values branch February 17, 2025 15:29
@nsenave nsenave mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsenave nsenave nsenave approved these changes

@laurentC35 laurentC35 Awaiting requested review from laurentC35

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RemiVerriez @nsenave