Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature to convert a tracks file to a density map #114

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature to convert a tracks file to a density map #114

wants to merge 4 commits into from

Conversation

Gregoire-V
Copy link

Written by Thomas Durantel @todurante.

@Gregoire-V Gregoire-V self-assigned this Jun 6, 2024
@Gregoire-V Gregoire-V changed the title Add of a feature to convert a tracks file to a density map Feature to convert a tracks file to a density map Jun 6, 2024
@Florent2305 Florent2305 requested a review from astamm June 7, 2024 08:40
Florent2305
Florent2305 requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@Florent2305 Florent2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks to port Thomas' work in anima.
Can you statisfy "request changes" please.

Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx Outdated Show resolved Hide resolved
Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx Show resolved Hide resolved
Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx Outdated
outImage->SetPixel(index, 1);
}

double dist = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe dist need to be initialize to others values than 2. In this case, please create command line parameter.

Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx Outdated

double dist = 2;
double dx, dy, dz;
while(dist >= 1.5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe hard coded "1.5" value need a command line parameter to fix to another value.

Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx Show resolved Hide resolved
Florent2305
Florent2305 requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@Florent2305 Florent2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks to port Thomas' work in anima.
Can you statisfy "request changes" please.

Anima/math-tools/common_tools/shapes_to_density/animaShapesToDensity.cxx Show resolved Hide resolved
@Gregoire-V
Copy link
Author

@Florent2305 I modified the main algorithm to compute the density map, because it seems to me that Thomas Durantel's implementation has drawbacks. In this new implementation, the sgn function is no longer used, and neither is the dist variable, so these change requests no longer apply.
I also added comments to explain what is being done. In addition, I tested the related new executable with two different track files (one from Trekker tractography algorithm with a smaller step size and one from iFod2 algorithm with a higher one).
Here are the command lines that I wrote for this test:
testShapesToDensity

Could you please have a look at this new implementation of the main algorithm, and tell me if there are parts to modify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Florent2305 Florent2305 Florent2305 requested changes

@astamm astamm Awaiting requested review from astamm

Requested changes must be addressed to merge this pull request.

Assignees

@Gregoire-V Gregoire-V

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gregoire-V @Florent2305