Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature to create a mask from an image. #113

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Feature to create a mask from an image. #113

merged 2 commits into from
Jul 12, 2024

Conversation

Gregoire-V
Copy link

Written by Thomas Durantel @todurante

@Gregoire-V Gregoire-V self-assigned this Apr 29, 2024
@Florent2305 Florent2305 requested a review from astamm June 7, 2024 08:39
Florent2305
Florent2305 requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@Florent2305 Florent2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks to port Thomas' work in anima.
Can you statisfy "request changes" please.

Anima/math-tools/common_tools/image_to_mask/animaImageToMask.cxx Outdated Show resolved Hide resolved
Anima/math-tools/common_tools/image_to_mask/animaImageToMask.cxx Outdated Show resolved Hide resolved
Anima/math-tools/common_tools/image_to_mask/animaImageToMask.cxx Outdated Show resolved Hide resolved
Anima/math-tools/common_tools/image_to_mask/animaImageToMask.cxx Outdated Show resolved Hide resolved
Anima/math-tools/common_tools/image_to_mask/animaImageToMask.cxx Show resolved Hide resolved
@Florent2305
Copy link
Contributor

@Gregoire-V Can you make a manual test and put test results here, thank you.

@Gregoire-V
Copy link
Author

@Florent2305 Thank you for your feedback. I added comments and did the modifications you requested.
I tested the executable with both a scalar (FAImage.nii.gz) and a vector image (TODImage.nii.gz). In both cases, I get the expected mask. I joined to this message a screenshot of the command lines used for testing.
testImageToMask

Florent2305
Florent2305 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@Florent2305 Florent2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your work.
I will merge this PR imediatly. :)

@Florent2305 Florent2305 merged commit 68e7146 into Inria-Empenn:master Jul 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Florent2305 Florent2305 Florent2305 approved these changes

@astamm astamm Awaiting requested review from astamm

Assignees

@Gregoire-V Gregoire-V

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gregoire-V @Florent2305