Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix COMP: ITK build error with GCC 13 #110

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Florent2305
Copy link
Contributor

Fix #109 by:

  • Import the patch system from medInria.
  • Adapts it.
  • Create a patch for ITK with the new GCC version.

Adapts it.
Create a patch for ITK with the new GCC version.
Copy link
Contributor

@astamm astamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You fix this as a patch. Does that mean it is not permanent and should be addressed in a better way later?

@Florent2305
Copy link
Contributor Author

Florent2305 commented Mar 25, 2024

You fix this as a patch. Does that mean it is not permanent and should be addressed in a better way later?

Hello, I am fixit in a patch because you have to patch ITK to compile it. No other good solution.
The problem is divided into two parts:

  • Anima (great project) needs a patching system. Because in many cases, it is absolutely to patch a dependence on a third party (for weeks, months or years)
  • The patch itself is an "#inclued" to determine a type. This is due to the new organization of Gcc headers. In the ITK development branch this is already fixed but not in a release. So for a few months (waiting time for release + time to activate this version) we need the path. Afterwards, we simply remove the patch and the system is still in place for other future patching needs.

@astamm
Copy link
Contributor

astamm commented Mar 25, 2024

Thanks for the explanation! So we need to track when ITK will propagate the fix in release, right?

@Florent2305
Copy link
Contributor Author

Absolutely

@ecaruyer
Copy link
Contributor

Sounds good on my side - I successfully built with both recent (gcc 13.2.1) and older (gcc 11.3.0) GCC versions under Linux. @astamm do you want to merge it?

@Florent2305
Copy link
Contributor Author

Thanks for your review on my works :)

@astamm
Copy link
Contributor

astamm commented Apr 4, 2024

@Florent2305 : Should we merge #110 and #111 ?

@ecaruyer
Copy link
Contributor

All good, thanks @Florent2305 !

@ecaruyer ecaruyer merged commit de6136d into Inria-Empenn:master Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COMP: ITK build error with GCC 13
3 participants