start port over to the shared kzg lib #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @terencechain |
Inphi
approved these changes
Nov 14, 2022
beacon-chain/core/blob/sidecar.go
Outdated
| } | ||
| return nil | ||
| copy(kzgSidecar.BeaconBlockRoot[:], sidecar.BeaconBlockRoot) | ||
| copy(kzgSidecar.KZGAggregatedProof[:], sidecar.AggregatedProof) |
There was a problem hiding this comment.
nit: could simplify these using bytesutil.ToBytes48(proof) on L48
There was a problem hiding this comment.
nice, changed.
roberto-bayardo
force-pushed
the
use-kzg-lib
branch
from
7245056
to
4e1cf09
Compare
looking into this. |
roberto-bayardo
force-pushed
the
use-kzg-lib
branch
from
4e1cf09
to
00eb2cb
Compare
Ran the updates, and patched various bazel build issues. "bazel build //beacon-chain:beacon-chain" now runs successfully. |
roberto-bayardo
added a commit
that referenced
this pull request
Nov 16, 2022
* start port over to the shared kzg lib * have CL compute the aggregated proof for the block, per updated spec
roberto-bayardo
added a commit
that referenced
this pull request
Nov 16, 2022
roberto-bayardo
added a commit
that referenced
this pull request
Nov 16, 2022
* update to use latest kzg lib (#35) * Expose JSON GetBlock * start port over to the shared kzg lib (#37) * start port over to the shared kzg lib * have CL compute the aggregated proof for the block, per updated spec * start port over to the shared kzg lib (#37) (#38) * start port over to the shared kzg lib * have CL compute the aggregated proof for the block, per updated spec Co-authored-by: dancoffman <coffman@coinbase.com> Co-authored-by: Daniel Coffman <dgcoffman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still code to be moved from Prysm into the shared lib, but this should at least update Prysm fully to the latest EIP-4844 spec changes. All devnet e2e tests pass when running with the similarly upgraded geth.