Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set position and rotation of xr locomotion handler correctly #96

Merged
merged 2 commits into from
Mar 26, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 2 additions & 24 deletions Runtime/Locomotion/XRLocomotionHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,34 +14,12 @@ public class XRLocomotionHandler : BaseLocomotionHandler
/// <summary>
/// Current rotation of the XR Rig.
/// </summary>
public override Quaternion CurrentRotation
{
get
{
if (rigManipulationProvider != null)
{
return RigManipulationProvider.system.xrRig.rig.transform.rotation;
}

return Quaternion.identity;
}
}
public override Quaternion CurrentRotation => RigManipulationProvider.system.xrRig.transform.rotation;

/// <summary>
/// Current position of the XR Rig.
/// </summary>
public override Vector3 CurrentPosition
{
get
{
if (rigManipulationProvider != null)
{
return RigManipulationProvider.system.xrRig.rig.transform.position;
}

return Vector3.forward;
}
}
public override Vector3 CurrentPosition => RigManipulationProvider.system.xrRig.transform.position;

/// <summary>
/// Locomotion provider to directly manipulate the XR Rig.
Expand Down