Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: offset when grabbing multiple objects with attach points TRNG-1288 #75

Conversation

Gusinuhe
Copy link
Contributor

Description

Fixes: An issue that appears in interactable objects that have attach transform points after previously grab objects without attach transform points.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Grab an object that does not have an attach transform (it should be grabbed using precision grab), then grab another object that has an attach transform (it should be grabbed from the attach transform position).

@Luphoxa
Copy link

Luphoxa commented Nov 24, 2020

I tested this and it works. 👍

How I tested:
Tested by grabbing a bunch of objects in VR, somewith an attach transform set and the rest without :)
The attach transform objects all snapped to my hand on the attach transform position and the others I could grab with precision grab.
I also tried deleting the attach transform and removing it in the interactable object component. Those objects went back to precision grab always.

Copy link
Contributor

@Maxsiom Maxsiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and code looks good! 👍

@Gusinuhe Gusinuhe merged commit 5353f6a into develop Nov 27, 2020
@Gusinuhe Gusinuhe deleted the hotfix/precision-grab-no-longer-offset-interactors-with-attach-points-TRNG-1288 branch November 27, 2020 10:27
@ci-innoactive
Copy link
Collaborator

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants