The XR component is now compatible with IXIT v1.0.0-pre.1 TRNG-1271 #73
Conversation
|
Seems like detach will be called when the snapzone is destroyed eg. on exiting playmode, which creates this lovley NPE: NullReferenceException: Object reference not set to an instance of an object |
Gusinuhe
changed the title
| @@ -7,28 +7,29 @@ namespace Innoactive.CreatorEditor.XRInteraction | |||
| /// <summary> | |||
| /// Drawer class for <see cref="SnapZone"/>. | |||
| /// </summary> | |||
| [CustomEditor(typeof(SnapZone))] | |||
| [CustomEditor(typeof(SnapZone)), CanEditMultipleObjects] | |||
There was a problem hiding this comment.
👍 should see if we can use this more often cause I stumbled upon this problem with other components too
There was a problem hiding this comment.
Older XRIT versions did not support it, not sure because they forgot, they didn't want people to do it, or there was a logical reason but in the end, we just stick to their practices, since now they allow it natively, I guess it is safe for us too.
Gusinuhe
force-pushed
the
hotfix/xr-interaction-toolkit-compatibility
branch
from
7da9060
to
64b01fc
Compare
Gusinuhe
changed the title
There was a problem hiding this comment.
Tested:
- Upgrading old project from 0.9.4 to 0.10.0 ✔️
- Warning tested (set to new system, old system, and both) ✔️
- Created new training course with different snap zones (multi meshes, single meshes, ...) ✔️
Bugs when enabling the Interactable Highlighter on a cube object with 3 children: 🔴
- Mesh Renderer gets deactivated
- Those errors are shown:
NullReferenceException: Cube has no renderers to be highlighted.
Innoactive.Creator.XRInteraction.InteractableHighlighter.RefreshCachedRenderers () (at Assets/Innoactive/Creator/Components/XR-Interaction-Component/Runtime/Interaction/Highlighters/InteractableHighlighter.cs:392)
Innoactive.Creator.XRInteraction.InteractableHighlighter.ForceRefreshCachedRenderers () (at Assets/Innoactive/Creator/Components/XR-Interaction-Component/Runtime/Interaction/Highlighters/InteractableHighlighter.cs:365)
Innoactive.CreatorEditor.XRInteraction.InteractableHighlighterEditor.OnEnable () (at Assets/Innoactive/Creator/Components/XR-Interaction-Component/Editor/Interaction/InteractableHighlighterEditor.cs:78)
NullReferenceException: Object reference not set to an instance of an object
Innoactive.CreatorEditor.XRInteraction.InteractableHighlighterEditor.DrawTouchHighlightSection (Innoactive.CreatorEditor.XRInteraction.InteractableHighlighterEditor+HighlightCase highlightCase) (at Assets/Innoactive/Creator/Components/XR-Interaction-Component/Editor/Interaction/InteractableHighlighterEditor.cs:102)
Innoactive.CreatorEditor.XRInteraction.InteractableHighlighterEditor.OnInspectorGUI () (at Assets/Innoactive/Creator/Components/XR-Interaction-Component/Editor/Interaction/InteractableHighlighterEditor.cs:93)
UnityEditor.UIElements.InspectorElement+<>c__DisplayClass58_0.<CreateIMGUIInspectorFromEditor>b__0 () (at <bccb16a88ec4456dbf07978c418f407b>:0)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr)
|
This bug also happens with a simple game object (e.g. cube or sphere) alone. Just try to enable the |
It should be fixed now. |
feat: multiple interactables and interactors can now be edited at the same time feat: material support for URP and PSB fix: snap zones can be generated in groups
Gusinuhe
force-pushed
the
hotfix/xr-interaction-toolkit-compatibility
branch
from
1dd5040
to
d73100f
Compare
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
feat: component is compatible with older IXIT versions
feat: multiple interactables and interactors can now be edited at the same time
Description
Fixes: Incompatibility with the latest XR Interaction Toolkit version.
Type of change
How Has This Been Tested?
Importing different versions of the XR Interaction Toolkit.