fix: Prevent realmTransfers NullPointerException with coroutines #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirambd
approved these changes
Dec 17, 2024
LouisCAD
force-pushed
the
fix-realm-init-order
branch
from
6bb3e94 to
bc3dd64
Compare
sirambd
changed the title
Instead of depending on an init order that doesn't always happen as wanted, and having the !! footgun, we are leveraging coroutines to wait (if needed), until the instance we need is initialized.
LouisCAD
force-pushed
the
fix-realm-init-order
branch
from
bc3dd64 to
5772e3a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of depending on an init order that doesn't always happen as wanted, and having the !! footgun, we are leveraging coroutines to wait (if needed), until the instance we need is initialized.