Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add FilesDetailScreen #117

Merged
merged 94 commits into from
Jan 13, 2025
Merged

feat: Add FilesDetailScreen #117

merged 94 commits into from
Jan 13, 2025

Conversation

tevincent
Copy link
Contributor

@tevincent tevincent commented Oct 23, 2024 •
edited
Loading

Depends on #326

files_navigation.mp4

Depends on Infomaniak/multiplatform-SwissTransfer#81

Screen to display details of files provided by the parameter filesList.

Can be configured like this:

  • folderUuid: folder UUID in which we want to navigate
  • navigateToFolder: this callback is called when the user click on a file
  • withFileSize: if we want to display files size
  • withSpaceLeft: if we want to display the space left, useful when displaying files of a transfer
  • withFileDelete: if deletion of files is enable
  • navigateBack: this callback is called when the user want to navigate back

@tevincent tevincent marked this pull request as draft October 23, 2024 10:50
@tevincent tevincent force-pushed the details-files branch 3 times, most recently from 8c58665 to c57de0e Compare October 23, 2024 12:08
@tevincent tevincent changed the title Add FilesDetailScreen feat: Add FilesDetailScreen Oct 23, 2024
@tevincent tevincent marked this pull request as ready for review October 24, 2024 06:36
@tevincent tevincent marked this pull request as draft October 24, 2024 07:03
@tevincent tevincent marked this pull request as ready for review October 24, 2024 12:29
@tevincent tevincent force-pushed the details-files branch 2 times, most recently from 79c1b3e to 6295db8 Compare October 25, 2024 08:29
LunarX
LunarX requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this screen being used in another PR already? If it is, then it's fine like this but if it's not, we should use the screen already for the imported files during a new transfer, it could help see some details and issue we might not have thought about

app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferTopAppBar.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/MainNavHost.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/utils/HumanReadableSizeUtils.kt Outdated Show resolved Hide resolved
...java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/FilesDetailsViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/FilesSize.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/FilesSize.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt Outdated Show resolved Hide resolved
...in/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/FilesDetailsScreen.kt Outdated Show resolved Hide resolved
@tevincent tevincent force-pushed the details-files branch 3 times, most recently from 57b7150 to bb9b3b7 Compare October 30, 2024 13:52
tevincent
tevincent commented Oct 30, 2024
View reviewed changes
app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferTopAppBar.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/MainNavHost.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/utils/HumanReadableSizeUtils.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/FilesSize.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/FilesSize.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/utils/HumanReadableSizeUtils.kt Outdated Show resolved Hide resolved
@tevincent tevincent force-pushed the details-files branch 4 times, most recently from 6eb0c25 to d537d2b Compare October 31, 2024 10:37
@tevincent tevincent force-pushed the details-files branch 3 times, most recently from f295a40 to 749ed98 Compare November 4, 2024 13:24
@tevincent tevincent marked this pull request as draft January 9, 2025 07:49
@tevincent
Merge branch 'update-tablet-mode' into details-files
39fd854 
# Conflicts:
#	app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/received/ReceivedScreen.kt
#	app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/transferdetails/TransferDetailsViewModel.kt
@tevincent tevincent marked this pull request as ready for review January 10, 2025 09:04
Base automatically changed from update-tablet-mode to main January 10, 2025 10:58
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

LunarX
LunarX requested changes Jan 10, 2025
View reviewed changes
Core2/FileTypes/src/main/java/com/infomaniak/core2/filetypes/icons/Folder.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItem.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/FileItemList.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt Show resolved Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt Outdated Show resolved Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/ImportFilesScreen.kt Outdated Show resolved Hide resolved
...m/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/components/ImportedFilesCard.kt Outdated Show resolved Hide resolved
@tevincent tevincent marked this pull request as draft January 11, 2025 18:58
@tevincent tevincent force-pushed the details-files branch 2 times, most recently from 5dcdb4e to 3170b98 Compare January 13, 2025 07:34
@tevincent tevincent marked this pull request as ready for review January 13, 2025 13:50
@tevincent tevincent dismissed sirambd’s stale review January 13, 2025 13:59

Seen together with Gibran and Sisi

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tevincent tevincent merged commit 206babb into main Jan 13, 2025
6 checks passed
@tevincent tevincent deleted the details-files branch January 13, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX approved these changes

@sirambd sirambd sirambd left review comments

@KevinBoulongne KevinBoulongne Awaiting requested review from KevinBoulongne

Assignees

@tevincent tevincent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tevincent @sirambd @KevinBoulongne @LunarX