feat: support proxy and ssl #230
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 89.71% 86.29% -3.43%
==========================================
Files 18 18
Lines 963 1029 +66
Branches 150 159 +9
==========================================
+ Hits 864 888 +24
- Misses 39 73 +34
- Partials 60 68 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @bednar |
There was a problem hiding this comment.
Still in progress. But I've raised a couple of questions in the config file.
I was surprised to see that io.grpc.netty.GrpcSslContexts is tagged as @experimental and would not want to use "experimental" code in a public library. However, after digging around in https://github.com/grpc/grpc-java/blob/master/netty/src/main/java/io/grpc/netty/GrpcSslContexts.java I see that it has been experimental for 9 years... 😕
TBC
| private final Authenticator authenticator; | ||
| private final Map<String, String> headers; | ||
| private final SslContext grpcSslContext; |
There was a problem hiding this comment.
I don't see either grpcSslContext or sslContext in the Javadoc above the class.
| @@ -97,8 +102,11 @@ public final class ClientConfig { | |||
| private final Boolean allowHttpRedirects; | |||
| private final Boolean disableServerCertificateValidation; | |||
| private final ProxySelector proxy; | |||
| private final ProxyDetector queryApiProxy; | |||
There was a problem hiding this comment.
This self-descriptive naming might be more precise as grpcApiProxy or grpcProxy. It would also match with the grpcSslContext naming below.
Closes #
Proposed Changes
Add proxy support for query api
Checklist