-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the flakey two qubit IRB test #1085
Conversation
@@ -82,9 +81,14 @@ def test_irb_random_clifford() -> None: | |||
|
|||
|
|||
def test_random_two_qubit_clifford() -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's too many mocks going on here. Let's delete this test. There are quality end-to-end tests that are getting us the 100% coverage we need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've removed this test and added a random seed to test_gates_per_clifford()
which ensure we still get 100% coverage.
…/client-superstaq into fix/flakey_two_qubit_irb_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1084
Cause: The numpy random number generator didn't seem to be patched properly.
Solution: fix the patch and also path the single qubit Clifford generator so that it outputs a fixed value (not strictly necessary but leads to a more predictable test)