Fix the flakey two qubit IRB test #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtomole
reviewed
Oct 8, 2024
| @@ -82,9 +81,14 @@ def test_irb_random_clifford() -> None: | |||
|
|
|||
|
|
|||
| def test_random_two_qubit_clifford() -> None: | |||
There was a problem hiding this comment.
There's too many mocks going on here. Let's delete this test. There are quality end-to-end tests that are getting us the 100% coverage we need.
There was a problem hiding this comment.
Ok, I've removed this test and added a random seed to test_gates_per_clifford() which ensure we still get 100% coverage.
…/client-superstaq into fix/flakey_two_qubit_irb_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1084
Cause: The numpy random number generator didn't seem to be patched properly.
Solution: fix the patch and also path the single qubit Clifford generator so that it outputs a fixed value (not strictly necessary but leads to a more predictable test)