Fix uninitialised attributes in QCVV samples #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richrines1
reviewed
Sep 24, 2024
| } | ||
| ) | ||
| else: | ||
| warnings.warn("Sample is missing probabilities. This sample has been omitted.") |
There was a problem hiding this comment.
we might not want to repeat this warning for every missing sample
|
|
||
| for sample in tqdm.notebook.tqdm(samples, desc="Evaluating circuits"): | ||
| sample.target_probabilities = self._simulate_sample(sample) | ||
|
|
||
| records = [] | ||
| for sample in samples: | ||
| target_probabilities = { | ||
| f"p({key})": value for key, value in sample.target_probabilities.items() | ||
| f"p({key})": value | ||
| for key, value in sample.target_probabilities.items() # type: ignore[union-attr] |
There was a problem hiding this comment.
is it possible to avoid the type: ignore pragmas? e.g. with
Suggested change
| for key, value in sample.target_probabilities.items() # type: ignore[union-attr] | |
| for key, value in sample.target_probabilities.items() if sample.target_probabilities is not None |
or by combining this w/ the previous loop
There was a problem hiding this comment.
The logic meant that this case was never actually reached, hence the type: ignore. Just adding the not None check to the list comprehension doesn't work unfortunately so I've added an explicit check in the loop instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1071