SU2 benchmarking #1017
Open
SU2 benchmarking #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
richrines1
reviewed
Sep 24, 2024
Comment on lines
231
to
232
| self._haar_random_rotation().on(self.qubits[0]), | ||
| self._haar_random_rotation().on(self.qubits[1]), |
There was a problem hiding this comment.
i believe the same rotation is supposed to be applied to both gates, so that they can be done with a single global pulse on systems that support it (the language in the paper is "random global single-qubit rotations between sequences of CZ entangling gates")
There was a problem hiding this comment.
Sorry only just seen this comment.
Yes I agree, thanks. I must have misinterpreted the paper. Now fixed 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SU2 benchmarking to the QCVV library
Closes: #1006