feat: secret sharing #1886
Merged
feat: secret sharing #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilmhdh
requested changes
May 28, 2024
frontend/src/views/ShareSecretPage/components/AddShareSecretModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/views/ShareSecretPage/components/AddShareSecretModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/views/ShareSecretPage/components/ShareSecretsTable.tsx
Outdated
Show resolved
Hide resolved
frontend/src/views/ShareSecretPublicPage/ShareSecretPublicPage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/views/ShareSecretPublicPage/ShareSecretPublicPage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/views/ShareSecretPublicPage/ShareSecretPublicPage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/views/ShareSecretPage/components/AddShareSecretModal.tsx
Outdated
Show resolved
Hide resolved
ShubhamPalriwala
force-pushed
the
shubham/feat-secret-sharing
branch
from
3dcbed5 to
a93d350
Compare
ShubhamPalriwala
force-pushed
the
shubham/feat-secret-sharing
branch
from
a93d350 to
1068e60
Compare
akhilmhdh
reviewed
May 29, 2024
| const { actor, actorId, orgId, actorAuthMethod, actorOrgId, name, encryptedValue, iv, tag, hashedHex, expiresAt } = | ||
| createSharedSecretInput; | ||
| const { permission } = await permissionService.getOrgPermission(actor, actorId, orgId, actorAuthMethod, actorOrgId); | ||
| if (!permission) throw new UnauthorizedError({ name: "User not in org" }); |
There was a problem hiding this comment.
Just a suggestion: I think this is unneccessary as the getOrgPermission already does the check.
| const [tableData, setTableData] = useState<TSharedSecret[]>([]); | ||
| const { isLoading, data = [] } = useGetSharedSecrets(); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
You don't need to do useEffect pattern for derived state.
You can just put it in variable like this
const filteredData = data.filter((secret) => !secret.expiresAt || new Date(secret.expiresAt) > new Date())
There was a problem hiding this comment.
fixed, thanks
akhilmhdh
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Adds the ability to share secrets in a time-sensitive manner from the Infisical web dashboard with anybody (non-Infisical users as well) securely using a signing algorithm.
Loom Walkthrough
https://www.loom.com/share/cb54a37ae5724b5f85026425fe366e5a?sid=15e15f84-d447-4cf1-b5ef-90ac109c8621
Type ✨
Tests 🛠️