Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolved cloudflare pages integration #1872

Merged
merged 1 commit into from
May 24, 2024
Merged

fix: resolved cloudflare pages integration #1872

merged 1 commit into from
May 24, 2024

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented May 24, 2024 •
edited
Loading

Description 📣

  • This fixes existing integration issues with Cloudflare pages. Before this implementation, secrets are not created and synced to CF because of a parsing issue causing a "cannot convert undefined or null to object" rejection during the sync process
  • This also fixed the sync behavior of CF integration for when Infisical secrets are deleted. Before this implementation, synced secrets were inconsistent

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

maidul98
maidul98 reviewed May 24, 2024
View reviewed changes
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes make sense to me, approved

@sheensantoscapadngan sheensantoscapadngan merged commit c782df1 into main May 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidul98 maidul98 maidul98 approved these changes

@dangtony98 dangtony98 Awaiting requested review from dangtony98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheensantoscapadngan @maidul98