Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: secure mfa endpoints with improved rate limiting and account locking #1861

Merged
merged 11 commits into from
May 28, 2024
Merged

feat: secure mfa endpoints with improved rate limiting and account locking #1861

merged 11 commits into from
May 28, 2024

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented May 22, 2024 •
edited by maidul98
Loading

Description 📣

  • added progressive delay as well as user account locking after failed MFA attempts
  • users should be able to unlock their accounts via email interaction
  • when account is locked user can also remove lock by resetting password
  • finalized rate limiting for mfa endpoints

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@dangtony98 dangtony98 self-requested a review May 23, 2024 03:51
@maidul98 maidul98 removed the request for review from dangtony98 May 23, 2024 16:00
akhilmhdh
akhilmhdh requested changes May 23, 2024
View reviewed changes
backend/src/db/schemas/users.ts Outdated Show resolved Hide resolved
backend/src/server/routes/v1/user-router.ts Outdated Show resolved Hide resolved
backend/src/services/auth/auth-fns.ts Show resolved Hide resolved
frontend/src/views/Login/components/MFAStep/MFAStep.tsx Outdated Show resolved Hide resolved
backend/src/services/user/user-fns.ts Outdated Show resolved Hide resolved
backend/src/services/user/user-fns.ts Outdated Show resolved Hide resolved
backend/src/services/user/user-fns.ts Outdated Show resolved Hide resolved
backend/src/services/user/user-fns.ts Outdated Show resolved Hide resolved
backend/src/services/auth/auth-login-service.ts Show resolved Hide resolved
akhilmhdh
akhilmhdh requested changes May 23, 2024
View reviewed changes
Copy link
Member

@akhilmhdh akhilmhdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some doubts

@sheensantoscapadngan sheensantoscapadngan merged commit 44b1475 into main May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilmhdh akhilmhdh akhilmhdh approved these changes

@maidul98 maidul98 maidul98 approved these changes

@dangtony98 dangtony98 Awaiting requested review from dangtony98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheensantoscapadngan @maidul98 @akhilmhdh