Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for BLE FS #839

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Add documentation for BLE FS #839

merged 2 commits into from
Dec 20, 2021

Conversation

Elara6331
Copy link
Contributor

This PR adds documentation for the BLE side of the BLE FS protocol, as implemented in #756, and will be updated with the mentioned PR.

@Elara6331 Elara6331 marked this pull request as draft November 22, 2021 00:59
@JF002 JF002 added this to the 1.8.0 milestone Dec 6, 2021
@JF002
Copy link
Collaborator

JF002 commented Dec 6, 2021

I think it would be nice to merge this PR at (more or less) the same time than #756.
@Arsen6331 Does it still need some work or only reviews?

@Elara6331
Copy link
Contributor Author

I think it would be nice to merge this PR at (more or less) the same time than #756. @Arsen6331 Does it still need some work or only reviews?

BLE FS is probably going to have some changes, and I need to document those changes as they occur. The current version is ready for the current version of BLE FS.

@Elara6331
Copy link
Contributor Author

It should be ready for merge at the same time as BLE FS, since I will document the changes as they happen.

Copy link
Member

@geekbozu geekbozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of right now I'm quite happy with this. The holiday season has kept me busy from shaping up the actual implementation of the BLE FS but @Arsen6331 has done a great service getting the documentation done!

I do not for see any major changes just additions, However this can all be crossed as we get there. For now getting a functional base so we can start to get companion app integration and move assets off to external flash is the main goal!

@Elara6331 Elara6331 marked this pull request as ready for review December 9, 2021 18:50
@JF002 JF002 merged commit 8ab959b into InfiniTimeOrg:develop Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants