Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Swipe up to unlock screen #723

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

coxtor
Copy link
Contributor

@coxtor coxtor commented Oct 5, 2021

This is a unfinished POC of a screen lock feature and I'm happy to discuss the features here like:

lockscreen.mp4
  • What parameters should be configurable?
  • When should the screen be locked?
  • Should the screen lock, if the watch is activated using the button?
  • Should a button press also unlock the watch?
  • Is the way of implementing this the correct approach?

@hubmartin
Copy link
Contributor

[thanks for video.. I was already asking for it, then you added it :) ]
Can you explain what led you to create this so we could better understand the need of it?

My watch sometimes turn on unintentionally only on wake-on-wrist. Never on pressing the button, maybe few times on doubleclick. So now I don't use wake on wrist and use doubleclick or the new ShakeWake™ #691 seems rock solid.

Based on the video it is really thoughtful that the screen is fully visible, only a small text displays asking for swipe. Let's see what others will say.

@escoand
Copy link

escoand commented Oct 5, 2021

My watch sometimes turn on unintentionally only on wake-on-wrist. Never on pressing the button, maybe few times on doubleclick. So now I don't use wake on wrist and use doubleclick or the new ShakeWake™ #691 seems rock solid.

Same to me, only use the button to wake the device, but this is not what I wanted. My FitBit watch does exactly this swipe to unlock which is really needed.

@coxtor
Copy link
Contributor Author

coxtor commented Oct 6, 2021

[thanks for video.. I was already asking for it, then you added it :) ] Can you explain what led you to create this so we could better understand the need of it?

My watch sometimes turn on unintentionally only on wake-on-wrist. Never on pressing the button, maybe few times on doubleclick. So now I don't use wake on wrist and use doubleclick or the new ShakeWake™ #691 seems rock solid.

Based on the video it is really thoughtful that the screen is fully visible, only a small text displays asking for swipe. Let's see what others will say.

Essentially you summed it up why I feel that a unlock mechanism is necessary, the screen randomly wakes up from now and then. So in conjunction with certain wake options, like shake to wake or raise wrist this feature could be useful.
I'm open to changes, designwise and in implementation.

@coxtor coxtor mentioned this pull request Oct 6, 2021
@darkdragon-001
Copy link

I am not sure if this is the right fix for a buggy wake-on-wrist. It creates double the effort to unlock the watch. I think an unlock feature only makes sense for privacy (e.g. entering a PIN to avoid others can see your notifications). Should be opt-in then though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants