Integrate color picker into PineTimeStyle watchface

[kieranc]

This PR aims to move the color picker functionality into the watchface, to avoid cluttering the settings list and potentially add color settings to other watchfaces.
The settings are now accessed with a long tap on the watchface, which shows a button - if the button is pressed within the timeout (currently 5 seconds), the color picker interface is loaded and can be used to change the colors as before. Otherwise the button disappears, this is to hopefully avoid accidental activation.
I plan to add a bit of logic to change the step gauge needle color depending on the background to fix #656 but I'm having a bit of trouble with my dev watch so I thought I'd create this PR to get some more eyes on the code first.

[Riksu9000]

Looks good. I like this being integrated with the watch face a lot better. The way the buttons appear and disappear probably due to the way the screen is refreshed is interesting.

Seems like going to the settings and swiping to a nonexistent third page crashes the firmware though.

[kieranc]

Thanks for your input Riku, I'm going to sort the gauge needle color later but I have noticed something of a bug if double tap to wake is enabled and I tap the buttons too fast, it turns the display off..
I've removed the 3rd screen from Settings.h which should resolve the crash.

[Riksu9000]

Doubletapping on the watchface puts the watch to sleep. I believe this can be disabled by returning true in OnTouchEvent() when the gesture is doubletap and the buttons are visible.

InfiniTime/src/displayapp/DisplayApp.cpp

Line 230 in 392c7ad

PushMessageToSystemTask(System::Messages::GoToSleep);

[kieranc]

I think there is a better way to implement the gauge needle color change but I haven't figured it out yet. As it stands if the BG is white/needle black and you hit randomise/reset, the needle stays black, until a reboot at least. I think I should be able to set it just once around line 167 but then I have to make sure the gauge is refreshed when closing the settings.

[kieranc]

So much for tidy commits... However, this seems to work as expected, I can't find a better solution to the needle color change so it gets checked when the gauge is created, when the bar BG is changed and on randomize/reset. Not elegant, but it works.

[Riksu9000]

I noticed that if you long press on the screen while the buttons are already visible, the big button appears anyway. Also I think pressing the back button should get rid of the buttons instead of going to sleep when the buttons are visible.

EDIT: also on sleep the buttons should probably go away.

[Riksu9000]

Can you make pressing the physical button close the color picker?

[kieranc]

Can you make pressing the physical button close the color picker?

Yes, absolutely, but possibly not until next week.

[Riksu9000]

This includes some changes by me, so someone else should check it too.

[kieranc]

So, with help from Riku and others, this finally works as intended. The button closes the picker instead of turning off the screen, and the notification icon and ble icon happily co-exist.

I'm not terribly happy with the code for the icon alignment and am open to suggestions on how to improve it - with the previous [notificationState|bleState].IsUpdated code it seemed to hit the else on the second refresh after displaying the notification icon and realiging the ble icon to the center. By using [notificationState|bleState].Get, it works, the only edge case is that if the ble disconnects and the notification icon is visible, it doesn't move to the center.
I'll give it some more thought tomorrow and see if I can find a better solution but otherwise this is functional and ready for testing.

[Riksu9000]

It would've been better to tweak the icons in a separate PR, because this PR was ready to merge, but now we need to work on the new changes too, which are not related to the color picker. If you were to revert those changes and work on them in another branch, we could get this merged quicker.

IsUpdated should be kept, as without it, the icons are refreshed with every cycle even if they haven't changed. It looks like you are aligning the icons next to each other. I think it would be preferrable if all the icons were aligned in a straight line. Have you tried aligning the icons relative to the previous icon, like in the digital watch face? That way when an icon disappears and all the icons are realigned, the later icons move back to fill the empty space.

[kieranc]

I could put the notification icon centrally aligned below the BLE icon and it wouldn't be too horrible, but it does need something doing since currently the BLE icon is at 0,25 and the notification icon is 0,40 and they overlap. I'll revert this and make a simpler fix later until i have a proper solution worked out.

[kieranc]

Ok it's done, both icon locations are static but they no longer overlap. It'll look a bit odd when there are notifications but no BLE connection, but I'll start working on a better fix. it's already an improvement on overlapping icons, and tbh the notification icon is very rarely displayed unless people accidentally activate silent mode...

[JF002]

Looks good to me, great work and nice collaboration @kieranc @Riksu9000 👍