-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic alarm app #662
Merged
Merged
Basic alarm app #662
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1fb5757
Created basic alarm app
mruss77 bfe13d9
Fixes based on code reviews (formatting, UI code)
mruss77 2bf339a
License header fix, add missing braces
mruss77 f857a75
Fixes per Riksu9000's feedback
mruss77 1d43adc
Merge upstream
mruss77 cdf99b0
Revert "Merge upstream"
mruss77 b9e5684
resolve conflict in src/systemtask/Messages.h
mruss77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
/* Copyright (C) 2021 mruss77, Florian | ||
|
||
This file is part of InfiniTime. | ||
|
||
InfiniTime is free software: you can redistribute it and/or modify | ||
it under the terms of the GNU General Public License as published | ||
by the Free Software Foundation, either version 3 of the License, or | ||
(at your option) any later version. | ||
|
||
InfiniTime is distributed in the hope that it will be useful, | ||
but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
GNU General Public License for more details. | ||
|
||
You should have received a copy of the GNU General Public License | ||
along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
*/ | ||
#include "AlarmController.h" | ||
#include "systemtask/SystemTask.h" | ||
#include "app_timer.h" | ||
#include "task.h" | ||
#include <chrono> | ||
|
||
using namespace Pinetime::Controllers; | ||
using namespace std::chrono_literals; | ||
|
||
AlarmController::AlarmController(Controllers::DateTime& dateTimeController) : dateTimeController {dateTimeController} { | ||
} | ||
|
||
APP_TIMER_DEF(alarmAppTimer); | ||
|
||
namespace { | ||
void SetOffAlarm(void* p_context) { | ||
auto* controller = static_cast<Pinetime::Controllers::AlarmController*>(p_context); | ||
if (controller != nullptr) { | ||
controller->SetOffAlarmNow(); | ||
} | ||
} | ||
} | ||
|
||
void AlarmController::Init(System::SystemTask* systemTask) { | ||
app_timer_create(&alarmAppTimer, APP_TIMER_MODE_SINGLE_SHOT, SetOffAlarm); | ||
this->systemTask = systemTask; | ||
} | ||
|
||
void AlarmController::SetAlarm(uint8_t alarmHr, uint8_t alarmMin) { | ||
hours = alarmHr; | ||
minutes = alarmMin; | ||
state = AlarmState::Set; | ||
ScheduleAlarm(); | ||
} | ||
|
||
void AlarmController::ScheduleAlarm() { | ||
// Determine the next time the alarm needs to go off and set the app_timer | ||
app_timer_stop(alarmAppTimer); | ||
|
||
auto now = dateTimeController.CurrentDateTime(); | ||
alarmTime = now; | ||
time_t ttAlarmTime = std::chrono::system_clock::to_time_t(alarmTime); | ||
tm* tmAlarmTime = std::localtime(&ttAlarmTime); | ||
|
||
// If the time being set has already passed today,the alarm should be set for tomorrow | ||
if (hours < dateTimeController.Hours() || (hours == dateTimeController.Hours() && minutes <= dateTimeController.Minutes())) { | ||
tmAlarmTime->tm_mday += 1; | ||
// tm_wday doesn't update automatically | ||
tmAlarmTime->tm_wday = (tmAlarmTime->tm_wday + 1) % 7; | ||
} | ||
|
||
tmAlarmTime->tm_hour = hours; | ||
tmAlarmTime->tm_min = minutes; | ||
tmAlarmTime->tm_sec = 0; | ||
|
||
// if alarm is in weekday-only mode, make sure it shifts to the next weekday | ||
if (recurrence == RecurType::Weekdays) { | ||
if (tmAlarmTime->tm_wday == 0) { // Sunday, shift 1 day | ||
tmAlarmTime->tm_mday += 1; | ||
} else if (tmAlarmTime->tm_wday == 6) { // Saturday, shift 2 days | ||
tmAlarmTime->tm_mday += 2; | ||
} | ||
} | ||
tmAlarmTime->tm_isdst = -1; // use system timezone setting to determine DST | ||
|
||
// now can convert back to a time_point | ||
alarmTime = std::chrono::system_clock::from_time_t(std::mktime(tmAlarmTime)); | ||
auto mSecToAlarm = std::chrono::duration_cast<std::chrono::milliseconds>(alarmTime - now).count(); | ||
app_timer_start(alarmAppTimer, APP_TIMER_TICKS(mSecToAlarm), this); | ||
} | ||
|
||
uint32_t AlarmController::SecondsToAlarm() { | ||
return std::chrono::duration_cast<std::chrono::seconds>(alarmTime - dateTimeController.CurrentDateTime()).count(); | ||
} | ||
|
||
void AlarmController::DisableAlarm() { | ||
app_timer_stop(alarmAppTimer); | ||
state = AlarmState::Not_Set; | ||
} | ||
|
||
void AlarmController::SetOffAlarmNow() { | ||
state = AlarmState::Alerting; | ||
systemTask->PushMessage(System::Messages::SetOffAlarm); | ||
} | ||
|
||
void AlarmController::StopAlerting() { | ||
systemTask->PushMessage(System::Messages::StopRinging); | ||
|
||
// Alarm state is off unless this is a recurring alarm | ||
if (recurrence == RecurType::None) { | ||
state = AlarmState::Not_Set; | ||
} else { | ||
state = AlarmState::Set; | ||
// set next instance | ||
ScheduleAlarm(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
/* Copyright (C) 2021 mruss77, Florian | ||
|
||
This file is part of InfiniTime. | ||
|
||
InfiniTime is free software: you can redistribute it and/or modify | ||
it under the terms of the GNU General Public License as published | ||
by the Free Software Foundation, either version 3 of the License, or | ||
(at your option) any later version. | ||
|
||
InfiniTime is distributed in the hope that it will be useful, | ||
but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
GNU General Public License for more details. | ||
|
||
You should have received a copy of the GNU General Public License | ||
along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
*/ | ||
#pragma once | ||
|
||
#include <cstdint> | ||
#include "app_timer.h" | ||
#include "components/datetime/DateTimeController.h" | ||
|
||
namespace Pinetime { | ||
namespace System { | ||
class SystemTask; | ||
} | ||
namespace Controllers { | ||
class AlarmController { | ||
public: | ||
AlarmController(Controllers::DateTime& dateTimeController); | ||
|
||
void Init(System::SystemTask* systemTask); | ||
void SetAlarm(uint8_t alarmHr, uint8_t alarmMin); | ||
void DisableAlarm(); | ||
void SetOffAlarmNow(); | ||
uint32_t SecondsToAlarm(); | ||
void StopAlerting(); | ||
enum class AlarmState { Not_Set, Set, Alerting }; | ||
enum class RecurType { None, Daily, Weekdays }; | ||
uint8_t Hours() const { | ||
return hours; | ||
} | ||
uint8_t Minutes() const { | ||
return minutes; | ||
} | ||
AlarmState State() const { | ||
return state; | ||
} | ||
RecurType Recurrence() const { | ||
return recurrence; | ||
} | ||
void SetRecurrence(RecurType recurType) { | ||
recurrence = recurType; | ||
} | ||
|
||
private: | ||
Controllers::DateTime& dateTimeController; | ||
System::SystemTask* systemTask = nullptr; | ||
uint8_t hours; | ||
uint8_t minutes; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are uninitialized, and should probably be set to around 7 o'clock by default instead of midnight. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agree, initialized hours to 7 and minutes to 0 |
||
std::chrono::time_point<std::chrono::system_clock, std::chrono::nanoseconds> alarmTime; | ||
AlarmState state = AlarmState::Not_Set; | ||
RecurType recurrence = RecurType::None; | ||
void ScheduleAlarm(); | ||
}; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I change the time without enabling the alarm, the new time won't be saved. Perhaps this function could just set the time, and ScheduleAlarm() could be made public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - changed SetAlarm to SetAlarmTime and made ScheduleAlarm public.