Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set BLE icon on WatchFaceDigital to brighter color to better see on sunlight #556

Merged
merged 3 commits into from
Dec 30, 2021

Conversation

hubmartin
Copy link
Contributor

@hubmartin hubmartin commented Aug 4, 2021

When you're on a bright sunlight, then the blue BLE icon is not easily visible on black background. This is more important when I ride a bike and phone is in my backpack so I could easily check whether I'm connected and don't miss notifications.

image

I like colorful LCD display but in practice the white text is the most readable.

Similar ui PRs/issues:
#540
#555

@Avamander
Copy link
Collaborator

Configurable please.

@Riksu9000
Copy link
Contributor

The official color for bluetooth is R: 0 G: 130 B: 252 (#0082FC) according to bluetooth brand guide. Maybe with that it would be bright enough since it is be brighter than the #0000FF used currently.

@hatmajster
Copy link
Contributor

I think this is a general problem in sunlight, related to whole system and not only bluetooth. I think it would be very nice if Infinitime could have another, MAX brightness setting - make everything white, and the background black - so essentially huge contrast option.

@hubmartin
Copy link
Contributor Author

@Avamander Someone else would need to do that configurable.
@Riksu9000 good point, I set #0082FC. It is practically same, but looks beter and it is on-spec.
I would call this a day, forget the white and keep #0082FC.
Let me know if I should delete this PR in case you apply this fix in your #555

Can you tell the difference? :)
image

@hubmartin hubmartin changed the title Set BLE icon on WatchFaceDigital to white to better see on sunlight when BLE disconnects Set BLE icon on WatchFaceDigital to brighter color to better see on sunlight Aug 4, 2021
@hatmajster
Copy link
Contributor

It looks a lot nicer on my pinetime. Though I can't tell if its really better for sunlight...
Its such a simple change that maybe JF002 will just merge this, so I would've left this PR. Maybe there are bluetooth icons in other places where You can also change this?

@jonvmey
Copy link
Contributor

jonvmey commented Aug 5, 2021

The bluetooth icon is also displayed on the PineTimeStyle watchface if you wanted to change the colour there too.

@JF002 JF002 added this to the 1.8.0 milestone Dec 30, 2021
@JF002
Copy link
Collaborator

JF002 commented Dec 30, 2021

Colors are a matter of personal taste, but in this is a case of spec compliance, so... I merge 👍

@JF002 JF002 merged commit 204fc56 into InfiniTimeOrg:develop Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants