-
-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PineTimeStyle watchface #334
Conversation
Thanks for this PR, your watchface looks really nice! As we are trying to rationalize the usage of the flash memory (see here), would it be possible to measure the impact on memory usage (mostly flash, I guess) of this PR (just compare the size of the binary file with |
If my previous analysis is correct, 12.1kB. I guess this is largely down to the new font, there are no other significant assets added. |
@kieranc whoops, this branch is a bit off, a lot of old commits. Please rebase on latest JF002:develop. (If you are unsure, you can create a full copy of your current working folder, test your commands there and if nothing went wrong, apply them on the "backup") |
This reverts commit 378fa6b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs testing, the rest is great!
@kieranc I've just tried PineTimeStyle on my devkit : it's really nice! I might be able to merge it since we've freed some space in flash memory :) By any chance, do you still have the original font file? It would be nice to add it to the project and update the font documentation with instruction on how to re-generate it (mostly the characters ranges). |
I downloaded the font from here |
Don't forget to check the license of the font, to ensure we can use it in an opensource project :) I can help with the conflict, they are caused by merges I did sooner today. |
I've just fixed the conflicts :) |
Thanks! |
Indeed, Apache 2.0 should be OK :) Could you add the source file of the font to the project so we can easily re-generate it if needed ? This way, we ensure that everyone use the same version of the font and avoid this. |
Font source file added! |
This is looking really good! You know what might be missing ? A bit of doc on how to generate the font for this watchface (parameters for the generator, range of symbols,...). |
Thanks for this PR @kieranc ! |
I created this watchface based on TimeStyle for the Pebble with the permission of the original creator.
It looks like this: