Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PineTimeStyle watchface #334

Merged
merged 22 commits into from
Jun 29, 2021
Merged

Conversation

kieranc
Copy link
Contributor

@kieranc kieranc commented May 7, 2021

I created this watchface based on TimeStyle for the Pebble with the permission of the original creator.

It looks like this:

image

@JF002
Copy link
Collaborator

JF002 commented May 7, 2021

Thanks for this PR, your watchface looks really nice!

As we are trying to rationalize the usage of the flash memory (see here), would it be possible to measure the impact on memory usage (mostly flash, I guess) of this PR (just compare the size of the binary file with master or the 1.0 tag, for example) ?

@kieranc
Copy link
Contributor Author

kieranc commented May 7, 2021

If my previous analysis is correct, 12.1kB. I guess this is largely down to the new font, there are no other significant assets added.

@Avamander
Copy link
Collaborator

Avamander commented May 16, 2021

@kieranc whoops, this branch is a bit off, a lot of old commits. Please rebase on latest JF002:develop. (If you are unsure, you can create a full copy of your current working folder, test your commands there and if nothing went wrong, apply them on the "backup")

src/displayapp/screens/PineTimeStyle.cpp Outdated Show resolved Hide resolved
src/libs/lv_conf.h Outdated Show resolved Hide resolved
src/displayapp/screens/PineTimeStyle.cpp Outdated Show resolved Hide resolved
src/displayapp/screens/PineTimeStyle.cpp Outdated Show resolved Hide resolved
src/displayapp/screens/PineTimeStyle.cpp Outdated Show resolved Hide resolved
src/displayapp/screens/Clock.cpp Outdated Show resolved Hide resolved
src/displayapp/screens/settings/SettingWatchFace.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@Avamander Avamander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs testing, the rest is great!

@JF002
Copy link
Collaborator

JF002 commented Jun 12, 2021

@kieranc I've just tried PineTimeStyle on my devkit : it's really nice! I might be able to merge it since we've freed some space in flash memory :)

By any chance, do you still have the original font file? It would be nice to add it to the project and update the font documentation with instruction on how to re-generate it (mostly the characters ranges).

@kieranc
Copy link
Contributor Author

kieranc commented Jun 12, 2021

I downloaded the font from here
I used the existing documentation to generate the font using the lvgl online converter, just listing the symbols and not using a range.
It looks like I have a conflict before it can be merged - I'll try deal with it in the next couple of days.

@JF002
Copy link
Collaborator

JF002 commented Jun 12, 2021

Don't forget to check the license of the font, to ensure we can use it in an opensource project :)

I can help with the conflict, they are caused by merges I did sooner today.

@JF002
Copy link
Collaborator

JF002 commented Jun 12, 2021

I've just fixed the conflicts :)

@kieranc
Copy link
Contributor Author

kieranc commented Jun 14, 2021

Thanks!
As someone else commented, Open Sans is licensed with Apache 2.0 so as far as I'm aware we can use it without issues.

@JF002
Copy link
Collaborator

JF002 commented Jun 22, 2021

Thanks!
As someone else commented, Open Sans is licensed with Apache 2.0 so as far as I'm aware we can use it without issues.

Indeed, Apache 2.0 should be OK :)

Could you add the source file of the font to the project so we can easily re-generate it if needed ? This way, we ensure that everyone use the same version of the font and avoid this.

@JF002 JF002 added this to the Version 1.3 milestone Jun 22, 2021
@kieranc
Copy link
Contributor Author

kieranc commented Jun 22, 2021

Thanks!
As someone else commented, Open Sans is licensed with Apache 2.0 so as far as I'm aware we can use it without issues.

Indeed, Apache 2.0 should be OK :)

Could you add the source file of the font to the project so we can easily re-generate it if needed ? This way, we ensure that everyone use the same version of the font and avoid this.

Font source file added!

@JF002
Copy link
Collaborator

JF002 commented Jun 26, 2021

This is looking really good!

You know what might be missing ? A bit of doc on how to generate the font for this watchface (parameters for the generator, range of symbols,...).

@JF002
Copy link
Collaborator

JF002 commented Jun 29, 2021

Thanks for this PR @kieranc !
I've been using this watchface for a few days and it's been awesome ! Really good looking and easily readable! Merging for InfiniTime 1.3!

@JF002 JF002 merged commit f317d54 into InfiniTimeOrg:develop Jun 29, 2021
@kieranc kieranc deleted the pinetimestyle branch July 12, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants